fix(types): change QueryBuilderParams keys to partial
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 5c9f6ca |
Tahul
approved these changes
Jun 3, 2022
|
You are totally right, I've also encountered that problem before and I'm so happy you fixed it! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
I wanted to modify the query for a
<ContentNavigation>, the docs specify you can provide a type ofQueryBuilderParams. When typing aQueryBuilderParamsthough, it requires all fields to be provided.I could get around this using
Partial, but better to accurately represent the params, it's not guaranteed that any specific key will be available.📝 Checklist